Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root path exclude conflict fix #355

Closed
wants to merge 2 commits into from
Closed

Root path exclude conflict fix #355

wants to merge 2 commits into from

Conversation

fabianbadoi
Copy link
Contributor

Hi,

Currently, trying to run phpmetrics on paths containing any default excluded names (vendor, test, spec) fails because no files are found.

Here are some examples:

/home/tester/project-root/main.php	path contains "test"
./projects/respect/folder/		path contains "spec"

This situation happened when the path of scanned file contained any of
the default excludes, for example:
/home/tester/project-root/main.php	path contains "test"
./projects/respect/folder/		path contains "spec"
@UFOMelkor
Copy link
Member

Looks good to me 👍
I've added a test case and merged it manually (eb9945b and a658ac1). Thank you very much 😊

@UFOMelkor UFOMelkor closed this Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants