Code is now compatible with PHP8 #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlakis
reviewed
May 26, 2021
| "license": "proprietary", | ||
| "require": { | ||
| "php": "^7.4", | ||
| "php": "^7.4|^8.0", |
There was a problem hiding this comment.
@Bal2018 can you update this to be "^7.4 || ^8.0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature/ Issue Description
Code was giving issues with using php 8 on my local when the packages initially installed were for php 7.4.
The final issue I came across was
Script security-checker security:check returned with error code 1.Discovered that "symfony/(recently) got rid of its security package and so had to uninstall this.
Code Explanation
Updated :
And uninstalled :
composer remove sensiolabs/security-checkerIn the code base updated .env file to include app path and correct port number