Additional PropertyAssembler not working - any ideas why?

[trailsnail]

Hi there,

after successful upgrade weeks ago where we discussed some details in #529 we are upgrading the next project.

Here I want to create a specific class with protected properties instead of default private depending on Typename with a TypenameMatchesRule:
If class ShipmentDetailsType is generated, I want to have protected properties.

soap-client.php

...

 Config::create()
    ->setEngine($engine = DefaultEngineFactory::create(
        ExtSoapOptions::defaults('C:\dvl\DefaultWorkspace\kunzmann\soap\dhl\config\geschaeftskundenversand-api-3.2.0.wsdl', [])
            ->disableWsdlCache()
    ))
    ->setTypeDestination('soap/dhl\Type')
    ->setTypeNamespace('DhlApi\Type')
    ->setClientDestination('soap/dhl')
    ->setClientName('DhlClient')
    ->setClientNamespace('DhlApi')
    ->setClassMapDestination('soap/dhl')
    ->setClassMapName('DhlClassmap')
    ->setClassMapNamespace('DhlApi')
    ->addRule(new Rules\AssembleRule(new Assembler\GetterAssembler(new Assembler\GetterAssemblerOptions())))
    ->addRule(new Rules\AssembleRule(new Assembler\ImmutableSetterAssembler(
        new Assembler\ImmutableSetterAssemblerOptions()
    )))
    ->addRule(
        new Rules\IsRequestRule(
            $engine->getMetadata(),
            new Rules\MultiRule([
                new Rules\AssembleRule(new Assembler\RequestAssembler()),
                new Rules\AssembleRule(new Assembler\ConstructorAssembler(new Assembler\ConstructorAssemblerOptions())),
            ])
        )
    )
    ->addRule(
        new Rules\IsResultRule(
            $engine->getMetadata(),
            new Rules\MultiRule([
                new Rules\AssembleRule(new Assembler\ResultAssembler()),
            ])
        )
    )
    ->addRule(new Rules\TypenameMatchesRule(
        new Rules\AssembleRule(new Assembler\PropertyAssembler(PropertyGenerator::VISIBILITY_PROTECTED)),
        '/^ShipmentDetailsType$/'
    ))
    ->addRule(new Rules\TypenameMatchesRule(
        new Rules\AssembleRule(new Assembler\ExtendAssembler('DhlApi\Type\ShipmentDetailsType')),
        '/^ShipmentDetailsTypeType$/'
    ))
;

attached Rules in config

ruleSet: Phpro\SoapClient\CodeGenerator\Rules\RuleSet {#103
    -rules: array:10 [
      0 => Phpro\SoapClient\CodeGenerator\Rules\AssembleRule {#104
        -assembler: Phpro\SoapClient\CodeGenerator\Assembler\PropertyAssembler {#105
          -visibility: "private"
        }
      }
      1 => Phpro\SoapClient\CodeGenerator\Rules\AssembleRule {#106
        -assembler: Phpro\SoapClient\CodeGenerator\Assembler\ClassMapAssembler {#107}
      }
      2 => Phpro\SoapClient\CodeGenerator\Rules\AssembleRule {#108
        -assembler: Phpro\SoapClient\CodeGenerator\Assembler\ClientConstructorAssembler {#109}
      }
      3 => Phpro\SoapClient\CodeGenerator\Rules\AssembleRule {#110
        -assembler: Phpro\SoapClient\CodeGenerator\Assembler\ClientMethodAssembler {#111}
      }
      4 => Phpro\SoapClient\CodeGenerator\Rules\AssembleRule {#133
        -assembler: Phpro\SoapClient\CodeGenerator\Assembler\GetterAssembler {#134
          -options: Phpro\SoapClient\CodeGenerator\Assembler\GetterAssemblerOptions {#135
            -boolGetters: false
            -returnType: false
            -docBlocks: true
          }
        }
      }
      5 => Phpro\SoapClient\CodeGenerator\Rules\AssembleRule {#136
        -assembler: Phpro\SoapClient\CodeGenerator\Assembler\ImmutableSetterAssembler {#137
          -options: Phpro\SoapClient\CodeGenerator\Assembler\ImmutableSetterAssemblerOptions {#138
            -typeHints: false
            -returnTypes: false
            -docBlocks: true
          }
        }
      }
      6 => Phpro\SoapClient\CodeGenerator\Rules\IsRequestRule {#139
        -metadata: Soap\Engine\Metadata\LazyInMemoryMetadata {#158}
        -subRule: Phpro\SoapClient\CodeGenerator\Rules\MultiRule {#164
          -rules: array:2 [
            0 => Phpro\SoapClient\CodeGenerator\Rules\AssembleRule {#165
              -assembler: Phpro\SoapClient\CodeGenerator\Assembler\RequestAssembler {#166}
            }
            1 => Phpro\SoapClient\CodeGenerator\Rules\AssembleRule {#167
              -assembler: Phpro\SoapClient\CodeGenerator\Assembler\ConstructorAssembler {#168
                -options: Phpro\SoapClient\CodeGenerator\Assembler\ConstructorAssemblerOptions {#169
                  -typeHints: false
                  -docBlocks: true
                }
              }
            }
          ]
        }
        -requestTypes: null
      }
      7 => Phpro\SoapClient\CodeGenerator\Rules\IsResultRule {#170
        -metadata: Soap\Engine\Metadata\LazyInMemoryMetadata {#158}
        -subRule: Phpro\SoapClient\CodeGenerator\Rules\MultiRule {#171
          -rules: array:1 [
            0 => Phpro\SoapClient\CodeGenerator\Rules\AssembleRule {#172
              -assembler: Phpro\SoapClient\CodeGenerator\Assembler\ResultAssembler {#173}
            }
          ]
        }
        -responseTypes: null
      }
      8 => Phpro\SoapClient\CodeGenerator\Rules\TypenameMatchesRule {#174
        -subRule: Phpro\SoapClient\CodeGenerator\Rules\AssembleRule {#175
          -assembler: Phpro\SoapClient\CodeGenerator\Assembler\PropertyAssembler {#176
            -visibility: "protected"
          }
        }
        -regex: "/^ShipmentDetailsType$/"
      }
      9 => Phpro\SoapClient\CodeGenerator\Rules\TypenameMatchesRule {#177
        -subRule: Phpro\SoapClient\CodeGenerator\Rules\AssembleRule {#178
          -assembler: Phpro\SoapClient\CodeGenerator\Assembler\ExtendAssembler {#179
            -extendedClassName: "DhlApi\Type\ShipmentDetailsType"
          }
        }
        -regex: "/^ShipmentDetailsTypeType$/"
      }
    ]
  }

.. and now the question

The ExtendAssembler works correctly, but the custom PropertyGenerator seems not to be touched - my question is why?

[veewee]

Hello,

Most likely a typo since the types are not equal on both rules?

    ->addRule(new Rules\TypenameMatchesRule(
        new Rules\AssembleRule(new Assembler\PropertyAssembler(PropertyGenerator::VISIBILITY_PROTECTED)),
-        '/^ShipmentDetailsType$/'
+        '/^ShipmentDetailsTypeType$/'
    ))
    ->addRule(new Rules\TypenameMatchesRule(
        new Rules\AssembleRule(new Assembler\ExtendAssembler('DhlApi\Type\ShipmentDetailsType')),
        '/^ShipmentDetailsTypeType$/'
    ))

[trailsnail]

No, that is correct. SInce I has to extend ShipmentDetailsTypeType from ShipmentDetailsType, the properties from ShipmentDetailsType has to be protected, otherwise I have no access on them while using ShipmentDetailsTypeType

[trailsnail]

🤦🏻 Forget it - if using SOAP Client in version 3.3.0 instead of 2.x while migrating, all works fine. Class is generated as expected. Sorry for the disturbance 😄