This repository has been archived by the owner on May 29, 2024. It is now read-only.
Php53 #15
Merged
Php53 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2015
|
I would definitly go for doctrine/instantiator instead of using newInstance. Entities can have constructor parameters, so this code will fail on entities with constructor parameters. |
|
I think this PR is done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #14 this gives backwards compatibility to PHP 5.3.
Two commits here, the second one I need your eye for. PHP 5.3 does not support ReflectionInstance::newInstanceWithoutConstructor. 5.3 unit tests pass with my change but I don't know all the consequences of this change. Could we do the same thing with https://github.com/Ocramius/Instantiator ?