Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for PHPUnit 9.1 #16

Merged
merged 13 commits into from
Mar 24, 2020
Merged

Update for PHPUnit 9.1 #16

merged 13 commits into from
Mar 24, 2020

Conversation

sebastianbergmann
Copy link
Contributor

Second attempt, this time with minimal changes. Feel free to pick from this what you need/want.

Please note that the testSpyPredictionFailure() test fails, I do not know why.

I will deprecate PHPUnit's built-in integration in its master branch (to be released as PHPUnit 9.1 on April 3, 2020) soon and trust that this integration will be ready in time.

I am sorry for any inconvenience caused and will try to help with any further work to the best of my ability.

ProphecyTestCase.php Show resolved Hide resolved
ProphecyTestCase.php Outdated Show resolved Hide resolved
ProphecyTestCase.php Show resolved Hide resolved
ProphecyTestCase.php Show resolved Hide resolved
ProphecyTestCase.php Outdated Show resolved Hide resolved
@stof
Copy link
Member

stof commented Mar 24, 2020

Also, please update the list of PHP versions in .travis.yml as the min version is now PHP 7.3 (so we need to have 7.3 and 7.4 on Travis). I re-enabled Travis so it will run on next push.

Tests/ProphecyTestCaseTest.php Show resolved Hide resolved
ProphecyTestCase.php Show resolved Hide resolved
@stof stof merged commit 60d12f2 into phpspec:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants