Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #441: #526

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Revert #441: #526

wants to merge 10 commits into from

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Mar 17, 2021

Fixes #472, declares a new major bump to 2.0.

As suggested by @stof in #472 (comment), this is an attempt to revert #441 and go back to the old behavior, with a fast bailout when the prophecy hits an unregistered method call.
This avoids returning null in those cases, since it would probably lead to \TypeErrors or other unpredictable behaviours, as originally pointed out in https://github.com/phpspec/prophecy/pull/441/files#r388191626.

@Jean85
Copy link
Contributor Author

Jean85 commented Mar 17, 2021

Ouch, we would need to declare PHPSpec compatible with Prophecy 2.0 in advance 😢 I'll revert the dev-master alias change to make the build happy.

@ciaranmcnulty
Copy link
Member

If we're going to bump the version number we should re-think the behaviour more comprehensively

What do you think of #528 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callcenter returns null on non registered method call
4 participants