Manage AppBundle:MyEntity

[soullivaneuh]

This is a valid notation for getRepository, but it's not managed.

[ondrejmirtes]

Care to elaborate? Where can this definition be obtained and is it suitable from the point of a static analyzer?

[hkdobrev]

$config = $entityManager->getConfiguration()
$config->addEntityNamespace('Foo', 'Foo\\Bar');
// Use later as:
$entityManager->getRepository('Foo::Author');
// where Author is in the `Foo\Bar` namespace.

We don't use the Symfony framework but needed to add a namespace to be used by tools expecting it. So this could be used even outside the context of bundles.

[ondrejmirtes]

I need a way how to translate 'Foo::Author' -> Foo\Bar\Author.

[hkdobrev]

@ondrejmirtes Sure! Based on the above example:

$alias = 'Foo';
$namespace = $config->getEntityNamespace('Foo');
echo $namespace;
// Foo\Bar

[ondrejmirtes]

And now how to share configuration between the app and PHPStan 🤔 cc @lookyman do you think it’s possible?

On Tue, 23 Jan 2018 at 18:23, Haralan Dobrev ***@***.***> wrote: @ondrejmirtes <https://github.com/ondrejmirtes> Sure! Based on the above example: $alias = 'Foo';$namespace = $config->getEntityNamespace('Foo');echo $namespace;// Foo\Bar — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGZuAXvq6DvlpoQimz42-OjdKDtp8asks5tNhWdgaJpZM4Roqgx> .

-- Ondřej Mirtes

[hkdobrev]

An alternative:

// this recognises both aliases and namespace
$metadata = $entityManager->getClassMetadata('Foo::Author');
echo $metadata->getName();
// Foo\Bar\Author

[hkdobrev]

For this and other advanced Doctrine introspections to work in PHPStan, I'd think one needs to load the entity manager or registry in the PHPStan bootstrap.

[mhujer]

Isn't it possible to pass a entity classname to getRepository()? See the second example here http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/working-with-objects.html#by-primary-key

I think I have seen a PR deprecating this "aliasing" functionality in some of the Doctrine repositories, but I can't find it right now. Maybe @Majkl578 would know?

[hkdobrev]

Isn't it possible to pass a entity classname to getRepository()?

@mhujer It is definitely possible to pass the entity FQCN everywhere including getRepository. We are using it everywhere, but we needed to add a namespace to integrate with a library developed for the Symfony framework. I guess many people using Doctrine with Symfony bundle would need that as the convention there in the existing code is to use the bundle name as the namespace for entities in that bundle.

I think I have seen a PR deprecating this "aliasing" functionality in some of the Doctrine repositories, but I can't find it right now.

Thanks for that! Here is the PR: doctrine/orm#6935 This would be a breaking change in Doctrine 3.

I guess it's up to @ondrejmirtes to decide whether a functionality from Doctrine 2 which is being removed is worth supporting. Doctrine 3 is not out yet and I guess a lot of Doctrine-based projects would not be upgraded immediately.

[Majkl578]

Actually you should always use Foo::class as of PHP 5.5, it's more predictable and easier to analyze by SA tools. As @hkdobrev referenced, this feature will be removed in ORM 3.0. Therefore I think it's not worth solving as it would require additional effort for deprecated feature...

[ondrejmirtes]

I agree, if you want statically analyzable code, you should always Foo::class. Since this feature is removed in ORM 3.0, I'm closing this.

[soullivaneuh]

Looks fair enough. Thanks for the tip! 👍

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.