Calling QueryBuilder::update is updating the type of the vairable or $this.

[VincentLanglet]

\PHPStan\dumpType($this);
$this->getEntityManager()->getRepository(WaitingList::class)->createQueryBuilder('w')->update();
\PHPStan\dumpType($this);

give me

263    Dumped type: $this(App\Core\Workflow\WorkflowProductStoreEventSubscriber)     
265    Dumped type: Doctrine\ORM\QueryBuilder

In the same way

$repo = $this->getEntityManager()->getRepository(WaitingList::class);
$repo->createQueryBuilder('w')->update();
\PHPStan\dumpType($repo);

is giving Dumped type: Doctrine\ORM\QueryBuilder instead of a repository.

If I manually remove the QueryBuilderTypeSpecifyingExtension, it fix my issue.

[VincentLanglet]

I would say the part https://github.com/phpstan/phpstan-doctrine/blob/master/src/Type/Doctrine/QueryBuilder/QueryBuilderTypeSpecifyingExtension.php#L84-L86 is false.

while ($queryBuilderNode instanceof MethodCall) {
    $queryBuilderNode = $queryBuilderNode->var;
}

doesn't work when the var is not a QueryBuilder initially.

I can work on a PR but I would need some recommendation about the purpose of this class and how to fix it. @ondrejmirtes
Is there a way to check the variable is a QueryBuilder ?

[ondrejmirtes]

Fixed by #220

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.