Do not specify a variable which is not a query builder

[VincentLanglet]

Solve #219

[ondrejmirtes]

Hi, this needs a test.

[VincentLanglet]

Hi, this needs a test.

I had some trouble to write one but this is ok now.
Without my fix, the test is failing, I checked it.

[ondrejmirtes]

Makes sense, thank you!

[VincentLanglet]

Thanks !
If you have also time to review #218 and make a release after, it will help me a lot ! (and now I have to work on phpstan/phpstan-symfony#199 to find a fix ^^)

[ondrejmirtes]

Next release is going to be out after PHPStan 1.0 is released which is still a few weeks away.

[VincentLanglet]

Next release is going to be out after PHPStan 1.0 is released which is still a few weeks away.

I can still ignore the error I fixed in this PR, but the PR #218 is kinda blocking for me. Any recommendation in my situation ? Does requiring the dev-master branch of phpstan and the extensions could be stable enough to enjoy the recent bugfix without having too much issues ?

[ondrejmirtes]

Does requiring the dev-master branch of phpstan and the extensions could be stable enough to enjoy the recent bugfix without having too much issues ?

I can't recommend that. What you should do instead is to use your own fork of phpstan-doctrine with the fix. And then switch back to the original once it's released.

[VincentLanglet]

I can't recommend that. What you should do instead is to use your own fork of phpstan-doctrine with the fix. And then switch back to the original once it's released.

I thought about this solution, but since the current "state" of the repository is supporting the 1.0 version of phpstan https://github.com/phpstan/phpstan-doctrine/blob/master/composer.json#L10 ; I assumed it wouldn't work with the 0.12.99 version.

I'll try tomorrow to revert cf697be then.

[ondrejmirtes]

You can cherry-pick your commit on top of the latest phpstan-doctrine 0.12.x release.