Skip to content

Bump doctrine dependencies #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

VincentLanglet
Copy link
Contributor

No description provided.

@VincentLanglet VincentLanglet changed the base branch from 1.4.x to 1.3.x February 6, 2024 07:07
@VincentLanglet VincentLanglet force-pushed the bumpDevDependencies branch 5 times, most recently from a9a7dcb to df51eb8 Compare February 6, 2024 07:42
@VincentLanglet VincentLanglet force-pushed the bumpDevDependencies branch 4 times, most recently from a9c95b7 to 898eb68 Compare February 6, 2024 08:02
@ondrejmirtes
Copy link
Member

Hey, I plan to work on this myself, make sure not to waste any effort here :)

@VincentLanglet VincentLanglet force-pushed the bumpDevDependencies branch 4 times, most recently from 625d18d to 6d73016 Compare February 6, 2024 09:12
@VincentLanglet
Copy link
Contributor Author

Hey, I plan to work on this myself, make sure not to waste any effort here :)

Do you need any help on this ?

I would say that all tests should have both annotations and attributes to work with both old and new versions.
So I can try to add them when I have time.

@ondrejmirtes
Copy link
Member

I have different ideas but I need to verify them myself.

@VincentLanglet
Copy link
Contributor Author

I have different ideas but I need to verify them myself.

Ok, I'll stop for now then. Ping me if I can help.

@VincentLanglet
Copy link
Contributor Author

I have different ideas but I need to verify them myself.

I still wanted to try my strategy and I went from 100+ errors to around 20 currently,
by using both attributes and annotations everywhere.

I can keep going and trying to solve as possible errors that I can @ondrejmirtes

@ondrejmirtes
Copy link
Member

Please don't. I'm working ob this myself. In the end we can compare our approaches 😊

@VincentLanglet
Copy link
Contributor Author

Please don't. I'm working ob this myself. In the end we can compare our approaches 😊

Ok, I'll wait 😊

@ondrejmirtes
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants