BigInt support for DBAL 4 #539
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to disregard the 32-bit possibility, because it's 2024 and it's only about DBAL 4 which just came out: 719a8f4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to Closes #484
This will require #535
I'm currently not sure how we will handle the PHP32 bit situation to say that if it's not unsigned, we're sure it's integer.
Currently the unsigned data is not present in the descriptor.
I see multiple solutions with drawbacks @ondrejmirtes, I tried one.
Since the DoctrineTypeDescriptor is
@apiI'm not sure if we should create a new interface or if a better solution exists.Open to any suggestion.