Skip to content

Add Phpunit 9 compatibility #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2020
Merged

Add Phpunit 9 compatibility #74

merged 2 commits into from
May 31, 2020

Conversation

VincentLanglet
Copy link
Contributor

No description provided.

@VincentLanglet VincentLanglet changed the title Wip Add Phpunit 9 compatibility May 30, 2020
@VincentLanglet VincentLanglet marked this pull request as ready for review May 30, 2020 22:34
This was referenced May 30, 2020
Closed
Merged
williamdes
williamdes approved these changes May 30, 2020
View reviewed changes
Copy link

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ;)
Bonne nuit 🇫🇷

@ondrejmirtes
Copy link
Member

How is it that PHPUnit 7 has PHPUnit\Framework\MockObject\InvocationMocker but all of the versions also have PHPUnit\Framework\MockObject\Builder\InvocationMocker? Isn't it a different class with different purpose?

@ondrejmirtes
Copy link
Member

I can see the stub is already for the builder one, interesting...

@ondrejmirtes ondrejmirtes merged commit 74c1c5f into phpstan:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @ondrejmirtes @williamdes