Avoid addMethod issue with stdClass #93
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Mar 22, 2021
stubs/MockBuilder.stub
Outdated
Comment on lines
29
to
32
| /** | ||
| * @phpstan-return MockBuilder | ||
| */ | ||
| public function setMethods(array $methods = null) {} |
There was a problem hiding this comment.
@ondrejmirtes I thought this would have fixed #87
I would have expect that the MockBuilder will lose his template param
$this->getMockBuilder(Bar::class)
would be MockBuilder so
$this->getMockBuilder(Bar::class)->getMock()
would be MockObject&Bar but I wanted that
$this->getMockBuilder(Bar::class)->setMethods(...)
become something like MockBuilder so
$this->getMockBuilder(Bar::class)->setMethods(...)->getMock()
become MockObject&mixed and every method are allowed
This could be maybe a first step for solving the issue.
But it seems like I'm doing this wrong...
VincentLanglet
force-pushed
the
failingTest
branch
from
fd39be3 to
a0b166b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the tests are written with phpunit@7, I used
setMethods().But the issue also exists with
addMethods()