Deprecate old NoopRule

phpstan · May 6, 2024 · 1090835 · 1090835
1 parent 8102dae
commit 1090835
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -1824,6 +1824,22 @@ parameters:
 			count: 1
 			path: tests/PHPStan/Rules/Arrays/AppendedArrayKeyTypeRuleTest.php
 
+		-
+			message: """
+				#^Instantiation of deprecated class PHPStan\\\\Rules\\\\DeadCode\\\\NoopRule\\:
+				Replaced by PHPStan\\\\Rules\\\\DeadCode\\\\BetterNoopRule$#
+			"""
+			count: 1
+			path: tests/PHPStan/Rules/DeadCode/NoopRuleTest.php
+
+		-
+			message: """
+				#^Return type of method PHPStan\\\\Rules\\\\DeadCode\\\\NoopRuleTest\\:\\:getRule\\(\\) has typehint with deprecated class PHPStan\\\\Rules\\\\DeadCode\\\\NoopRule\\:
+				Replaced by PHPStan\\\\Rules\\\\DeadCode\\\\BetterNoopRule$#
+			"""
+			count: 1
+			path: tests/PHPStan/Rules/DeadCode/NoopRuleTest.php
+
 		-
 			message: "#^PHPDoc tag @var assumes the expression with type PHPStan\\\\Type\\\\Generic\\\\TemplateType is always PHPStan\\\\Type\\\\Generic\\\\TemplateMixedType but it's error\\-prone and dangerous\\.$#"
 			count: 1

diff --git a/src/Rules/DeadCode/NoopRule.php b/src/Rules/DeadCode/NoopRule.php
@@ -10,6 +10,7 @@
 use function sprintf;
 
 /**
+ * @deprecated Replaced by PHPStan\Rules\DeadCode\BetterNoopRule
  * @implements Rule<Node\Stmt\Expression>
  */
 class NoopRule implements Rule