Fixed IntersectionType::toBoolean()

phpstan · Jan 4, 2020 · 2b0013f · 2b0013f
1 parent 2a6901a
commit 2b0013f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/Type/IntersectionType.php b/src/Type/IntersectionType.php
@@ -326,11 +326,14 @@ public function isCloneable(): TrinaryLogic
 
 	public function toBoolean(): BooleanType
 	{
-		/** @var BooleanType $type */
 		$type = $this->intersectTypes(static function (Type $type): BooleanType {
 			return $type->toBoolean();
 		});
 
+		if (!$type instanceof BooleanType) {
+			return new BooleanType();
+		}
+
 		return $type;
 	}
 

diff --git a/tests/PHPStan/Type/IntersectionTypeTest.php b/tests/PHPStan/Type/IntersectionTypeTest.php
@@ -5,6 +5,7 @@
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\Accessory\HasOffsetType;
 use PHPStan\Type\Accessory\HasPropertyType;
+use PHPStan\Type\Accessory\NonEmptyArrayType;
 use PHPStan\Type\Constant\ConstantArrayType;
 use PHPStan\Type\Constant\ConstantIntegerType;
 use PHPStan\Type\Constant\ConstantStringType;
@@ -420,4 +421,10 @@ public function testIsSubTypeOfInversed(IntersectionType $type, Type $otherType,
 		);
 	}
 
+	public function testToBooleanCrash(): void
+	{
+		$type = new IntersectionType([new NeverType(), new NonEmptyArrayType()]);
+		$this->assertSame('bool', $type->toBoolean()->describe(VerbosityLevel::precise()));
+	}
+
 }