Fixed issue with arrow function type inference and TooWideArrowFuncti…

…onReturnTypehintRule
phpstan · Mar 17, 2020 · 5581928 · 5581928
1 parent 1d0d3ad
commit 5581928
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Rules/TooWideTypehints/TooWideArrowFunctionReturnTypehintRule.php b/src/Rules/TooWideTypehints/TooWideArrowFunctionReturnTypehintRule.php
@@ -29,7 +29,11 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$expr = $node->getOriginalNode()->expr;
+		$arrowFunction = $node->getOriginalNode();
+		if ($arrowFunction->returnType === null) {
+			return [];
+		}
+		$expr = $arrowFunction->expr;
 		if ($expr instanceof Node\Expr\YieldFrom || $expr instanceof Node\Expr\Yield_) {
 			return [];
 		}

diff --git a/tests/PHPStan/Rules/TooWideTypehints/data/tooWideArrowFunctionReturnType.php b/tests/PHPStan/Rules/TooWideTypehints/data/tooWideArrowFunctionReturnType.php
@@ -16,4 +16,11 @@ public function doFoo(?string $nullableString)
 		fn (): ?string => $nullableString;
 	}
 
+	public function doBar()
+	{
+		/** @var string[][] $data */
+		$data = doFoo();
+		array_reduce($data, static fn (int $carry, array $item) => $carry + $item['total_count'], 0);
+	}
+
 }