Detect calling static method on a trait

phpstan · Mar 16, 2020 · 67fc8f3 · 67fc8f3
1 parent ecef44f
commit 67fc8f3
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 0 deletions.
diff --git a/src/Rules/Methods/CallStaticMethodsRule.php b/src/Rules/Methods/CallStaticMethodsRule.php
@@ -138,6 +138,15 @@ public function processNode(Node $node, Scope $scope): array
 				}
 
 				$classReflection = $this->reflectionProvider->getClass($className);
+				if ($classReflection->isTrait()) {
+					return [
+						RuleErrorBuilder::message(sprintf(
+							'Call to static method %s() on trait %s.',
+							$methodName,
+							$className
+						))->build(),
+					];
+				}
 			}
 
 			$className = $classReflection->getName();

diff --git a/tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php b/tests/PHPStan/Rules/Methods/CallStaticMethodsRuleTest.php
@@ -216,6 +216,10 @@ public function testCallStaticMethods(): void
 				'Call to an undefined static method CallStaticMethods\Foo::nonexistentMethod().',
 				303,
 			],
+			[
+				'Call to static method doFoo() on trait CallStaticMethods\TraitWithStaticMethod.',
+				323,
+			],
 		]);
 	}
 

diff --git a/tests/PHPStan/Rules/Methods/data/call-static-methods.php b/tests/PHPStan/Rules/Methods/data/call-static-methods.php
@@ -304,3 +304,23 @@ public function doFoo(
 	}
 
 }
+
+trait TraitWithStaticMethod
+{
+
+	public static function doFoo(): void
+	{
+
+	}
+
+}
+
+class MethodCallingTraitWithStaticMethod
+{
+
+	public function doFoo(): void
+	{
+		TraitWithStaticMethod::doFoo();
+	}
+
+}