Turns out static property can be accessed on trait too

86c11d3
phpstan · Jun 7, 2021 · 688a87f · 688a87f
1 parent 10a833f
commit 688a87f
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 11 deletions.
diff --git a/src/Rules/Properties/AccessStaticPropertiesRule.php b/src/Rules/Properties/AccessStaticPropertiesRule.php
@@ -142,17 +142,6 @@ private function processSingleProperty(Scope $scope, StaticPropertyFetch $node,
 
 				$classType = $scope->resolveTypeByName($node->class);
 			}
-
-			$classReflection = $classType->getClassReflection();
-			if ($classReflection !== null && $classReflection->isTrait()) {
-				return [
-					RuleErrorBuilder::message(sprintf(
-						'Access to static property $%s on trait %s.',
-						$name,
-						$classReflection->getName()
-					))->build(),
-				];
-			}
 		} else {
 			$classTypeResult = $this->ruleLevelHelper->findTypeToCheck(
 				$scope,

diff --git a/tests/PHPStan/Rules/Properties/AccessStaticPropertiesRuleTest.php b/tests/PHPStan/Rules/Properties/AccessStaticPropertiesRuleTest.php
@@ -186,4 +186,9 @@ public function testClassExists(): void
 		$this->analyse([__DIR__ . '/data/static-properties-class-exists.php'], []);
 	}
 
+	public function testBug5143(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-5143.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Properties/data/bug-5143.php b/tests/PHPStan/Rules/Properties/data/bug-5143.php
@@ -0,0 +1,18 @@
+<?php
+
+namespace Bug5143;
+
+trait Foo
+{
+	public static $property = 0;
+}
+
+class Bar
+{
+
+	public function doFoo(): void
+	{
+		echo Foo::$property;
+	}
+
+}