Fix overriding SoapClient old-style constructor

phpstan · Nov 20, 2023 · 7765768 · 7765768
1 parent 53e7534
commit 7765768
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/src/Rules/Methods/OverridingMethodRule.php b/src/Rules/Methods/OverridingMethodRule.php
@@ -375,6 +375,8 @@ private function findPrototype(ClassReflection $classReflection, string $methodN
 						return null;
 					}
 				}
+			} elseif (strtolower($methodName) === '__construct') {
+				return null;
 			}
 		}
 

diff --git a/tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php b/tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php
@@ -810,4 +810,10 @@ public function testBug10153(): void
 		$this->analyse([__DIR__ . '/data/bug-10153.php'], $errors);
 	}
 
+	public function testBug10165(): void
+	{
+		$this->phpVersionId = PHP_VERSION_ID;
+		$this->analyse([__DIR__ . '/data/bug-10165.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Methods/data/bug-10165.php b/tests/PHPStan/Rules/Methods/data/bug-10165.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace Bug10165;
+
+class CustomSoapClient extends \SoapClient
+{
+	public function __construct(array $options = [])
+	{
+		parent::__construct('some.wsdl', $options);
+	}
+}