ArrayType::traverse() - create empty ConstantArrayType in case of never

phpstan · Mar 4, 2022 · 8c1dfc1 · 8c1dfc1
1 parent a84465b
commit 8c1dfc1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/Type/ArrayType.php b/src/Type/ArrayType.php
@@ -406,6 +406,10 @@ public function traverse(callable $cb): Type
 		$itemType = $cb($this->itemType);
 
 		if ($keyType !== $this->keyType || $itemType !== $this->itemType) {
+			if ($keyType instanceof NeverType && $itemType instanceof NeverType) {
+				return new ConstantArrayType([], []);
+			}
+
 			return new self($keyType, $itemType);
 		}
 

diff --git a/tests/PHPStan/Analyser/data/generics.php b/tests/PHPStan/Analyser/data/generics.php
@@ -931,7 +931,7 @@ public function returnStatic(): self
 function () {
 	$stdEmpty = new StdClassCollection([]);
 	assertType('PHPStan\Generics\FunctionsAssertType\StdClassCollection<*NEVER*, *NEVER*>', $stdEmpty);
-	assertType('array<*NEVER*, *NEVER*>', $stdEmpty->getAll());
+	assertType('array{}', $stdEmpty->getAll());
 
 	$std = new StdClassCollection([new \stdClass()]);
 	assertType('PHPStan\Generics\FunctionsAssertType\StdClassCollection<int, stdClass>', $std);