More verbose messages for IntegerRangeType

phpstan · May 20, 2021 · d23b4b7 · d23b4b7
1 parent fc9191a
commit d23b4b7
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/src/Type/VerbosityLevel.php b/src/Type/VerbosityLevel.php
@@ -70,6 +70,10 @@ public static function getRecommendedLevelByType(Type $acceptingType, ?Type $acc
 				$moreVerbose = true;
 				return $type;
 			}
+			if ($type instanceof IntegerRangeType) {
+				$moreVerbose = true;
+				return $type;
+			}
 			return $traverse($type);
 		};
 

diff --git a/tests/PHPStan/Rules/Methods/ReturnTypeRuleTest.php b/tests/PHPStan/Rules/Methods/ReturnTypeRuleTest.php
@@ -381,6 +381,10 @@ public function testBug3997(): void
 				'Method Bug3997\Lorem::count() should return int but returns string.',
 				48,
 			],
+			[
+				'Method Bug3997\Dolor::count() should return int<0, max> but returns -1.',
+				72,
+			],
 		]);
 	}
 

diff --git a/tests/PHPStan/Rules/Methods/data/bug-3997.php b/tests/PHPStan/Rules/Methods/data/bug-3997.php
@@ -62,3 +62,14 @@ public function count()
 	}
 
 }
+
+class Dolor implements  Countable
+{
+
+	/** @return positive-int|0 */
+	public function count(): int
+	{
+		return -1;
+	}
+
+}