PhpFunctionFromParserNodeReflection - fix optionality of parameters w…

…ith default value followed by variadic parmaeters

src/Reflection/Php/PhpFunctionFromParserNodeReflection.php

@@ -142,7 +142,7 @@ private function getParameters(): array
 
 		/** @var \PhpParser\Node\Param $parameter */
 		foreach (array_reverse($this->functionLike->getParams()) as $parameter) {
-			if (!$isOptional || $parameter->default === null) {
+			if ($parameter->default === null && !$parameter->variadic) {
 				$isOptional = false;
 			}
 
@@ -151,7 +151,7 @@ private function getParameters(): array
 			}
 			$parameters[] = new PhpParameterFromParserNodeReflection(
 				$parameter->var->name,
-				$isOptional || $parameter->variadic,
+				$isOptional,
 				$this->realParameterTypes[$parameter->var->name],
 				$this->phpDocParameterTypes[$parameter->var->name] ?? null,
 				$parameter->byRef

tests/PHPStan/Rules/Methods/OverridingMethodRuleTest.php

@@ -330,4 +330,10 @@ public function testBug3403(int $phpVersion): void
 		$this->analyse([__DIR__ . '/data/bug-3403.php'], []);
 	}
 
+	public function testBug3443(): void
+	{
+		$this->phpVersionId = PHP_VERSION_ID;
+		$this->analyse([__DIR__ . '/data/bug-3443.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Methods/data/bug-3443.php

@@ -0,0 +1,33 @@
+<?php
+
+namespace Bug3443;
+
+/**
+ * Interface Collection.
+ */
+interface CollectionInterface
+{
+
+	/**
+	 * @param mixed $data
+	 * @param mixed ...$parameters
+	 *
+	 * @return mixed
+	 */
+	public static function with($data = [], ...$parameters);
+
+}
+
+
+/**
+ * Class Collection.
+ */
+final class Collection implements CollectionInterface
+{
+
+	public static function with($data = [], ...$parameters)
+	{
+		return new self();
+	}
+
+}