Allow missing return for unions with void type

phpstan · Jan 12, 2020 · e208c05 · e208c05
1 parent 9665e16
commit e208c05
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/Rules/Missing/MissingReturnRule.php b/src/Rules/Missing/MissingReturnRule.php
@@ -65,7 +65,8 @@ public function processNode(Node $node, Scope $scope): array
 			throw new \PHPStan\ShouldNotHappenException();
 		}
 
-		if ($returnType instanceof VoidType) {
+		$isVoidSuperType = $returnType->isSuperTypeOf(new VoidType());
+		if ($isVoidSuperType->yes()) {
 			return [];
 		}
 

diff --git a/tests/PHPStan/Rules/Missing/data/missing-return.php b/tests/PHPStan/Rules/Missing/data/missing-return.php
@@ -397,3 +397,16 @@ public function bodySpecifiedVoidTReturn3(): \Generator
 	}
 
 }
+
+class VoidUnion
+{
+
+	/**
+	 * @return int|void
+	 */
+	public function doFoo()
+	{
+		echo 'test';
+	}
+
+}