Add @readonly rule that disallows default values #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
commented
Jun 2, 2022
herndlm
force-pushed
the
read-only-by-php-doc-property-rule
branch
from
b1c59da to
4fdea78
Compare
herndlm
commented
Jun 3, 2022
herndlm
force-pushed
the
read-only-by-php-doc-property-rule
branch
from
4fdea78 to
8f39f88
Compare
|
btw sorry, I didn't want to "summon" you with the force-push ;) |
|
Maybe test promoted property with |
herndlm
force-pushed
the
read-only-by-php-doc-property-rule
branch
from
8f39f88 to
98d1615
Compare
herndlm
commented
Jun 3, 2022
herndlm
force-pushed
the
read-only-by-php-doc-property-rule
branch
from
98d1615 to
61ad35f
Compare
herndlm
force-pushed
the
read-only-by-php-doc-property-rule
branch
from
61ad35f to
2e93957
Compare
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The counter-part to
ReadOnlyPropertyRule. I looked at that one already and thought it deals with only native readonly behaviour, but forbidding default values too might make sense in regard to use@readonlyfor smoother upgrades to native readonly?E.g. https://phpstan.org/r/0e1cd73e-6a9b-486f-8ae2-1781c0ff2eb4
feel free to just close this if you disagree, I thought it's easier to open the PR instead of starting a discussion / opening an issue :)