Narrow Closure::bind $newScope param

[mvorisek]

Same change as in JetBrains/phpstorm-stubs#1591.

Am I right the phpstorm-stubs are used for Pure metadata only?

The default type of newScope arg is 'static' which is not subtype of class-string, does phpstan imply that from the real reflection?

[phpstan-bot]

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

[phpstan-bot]

This pull request has been marked as ready for review.

[staabm]

The default type of newScope arg is 'static' which is not subtype of class-string, does phpstan imply that from the real reflection?

You could use NodeScopeResolverTest to check your assumptions

[ondrejmirtes]

Please do not rename parameter names

[mvorisek]

The default type of newScope arg is 'static' which is not subtype of class-string, does phpstan imply that from the real reflection?

You could use NodeScopeResolverTest to check your assumptions

Did you mean tests/PHPStan/Analyser/NodeScopeResolverTest.php? How can I assert a phpstan error message there if some non-class-string is passed?

[staabm]

In these tests you can only assert types. If you need to assert error messages you have to go with a rule-test

[mvorisek]

@ondrejmirtes I can added a test to tests\PHPStan\Rules\Functions\CallToFunctionParametersRuleTest.php, there is one simillar testBug4413 test. Please let me know how to name the testcase and if I should improve also other types like https://github.com/phpstan/phpstan-src/blob/1.10.57/resources/functionMap.php#L9929 which needs class-string too.

[ondrejmirtes]

Add whatever test you think is your best idea, I'll review if it's okay or not.

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

Thank you!