Fix return type of array_reverse() with optional keys
#3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
herndlm
commented
Sep 5, 2024
ondrejmirtes
requested changes
Sep 6, 2024
herndlm
force-pushed
the
fix-constant-array-reverse-with-optional-keys
branch
from
b38f709
to
61ccc70
Compare
|
This pull request has been marked as ready for review. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#11549
We cannot simply reverse indices and values for arrays with optional keys and preserve_keys=false. In that case the array has to be re-built to account for the optional keys properly.
fyi @tscni and thanks for the nice example / test case :)