Report invalid string offsets #3594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Oct 31, 2024
staabm
force-pushed
the
invalid-string-offsets
branch
2 times, most recently
from
4da3b92 to
0d2e494
Compare
|
This pull request has been marked as ready for review. |
staabm
commented
Oct 31, 2024
staabm
force-pushed
the
invalid-string-offsets
branch
2 times, most recently
from
ad6d064 to
cde20cd
Compare
staabm
commented
Nov 6, 2024
| @@ -3,3 +3,4 @@ parameters: | |||
| bleedingEdge: true | |||
| skipCheckGenericClasses!: [] | |||
| stricterFunctionMap: true | |||
| reportPossiblyNonexistentStringOffset: true | |||
There was a problem hiding this comment.
this might be enabled by default instead of using bleeding edge on 2.x, depending on how we decide here:
#3584 (comment)
staabm
force-pushed
the
invalid-string-offsets
branch
from
cde20cd to
a3b8bdf
Compare
clxmstaab
force-pushed
the
invalid-string-offsets
branch
from
a3b8bdf to
c886a22
Compare
clxmstaab
force-pushed
the
invalid-string-offsets
branch
from
c886a22 to
08359ca
Compare
|
leaving a note for myself: double check how this PR and phpstan/phpstan#12122 make sense in combination |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#11946