non-empty-array<mixed> does not accept array with hasOffsetValue #3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
staabm
commented
Apr 8, 2025
Comment on lines
+79
to
+83
| if ($type instanceof HasOffsetType | ||
| || $type instanceof HasOffsetValueType | ||
| ) { | ||
| return AcceptsResult::createYes(); | ||
| } |
There was a problem hiding this comment.
I am not 100% sure on this fix, as the 2 types do not necessarily mean "offset on array".
did not find a better place to implement it though.
staabm
changed the title
|
I see we have more todo here. a union of 2 non-empty-arrays with has-offset accessory atm is just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#12847