Added MissingArrayValueTypeInMethodParameterRule #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adaamz
force-pushed
the
array-types
branch
3 times, most recently
from
ebe3134 to
4668fdf
Compare
adaamz
changed the title
|
@ondrejmirtes Anything I can improve here? |
|
As I suggested in the other PR, this could be done in the existing rules for the sake of consistency. Feel free to join forces with @thewilkybarkid, thanks. |
|
Something like this? |
|
Yeah, similar to this, but it could work for all iterables, not just arrays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just want to make first step to array and iterable type checking.