Honor new contracts namespace as-of Symfony 4.2 for ServiceSubscriberInterface #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lookyman I might need your help to fix the CI. The tests are passing on my local machine under PHP 7.2. I just have no idea how the CI is dealing with composer's autoloader. The tests shouldn't even execute when the interface is not present 🤷♂️ |
|
Thanks, I'll have a look at it asap. |
…Interface In Symfony 4.2 the ServiceSubscriberInterface has been moved into its own contracts namespace. This commit adds support for the new interface and adds more test-coverage for all possible cases/combinations
lookyman
force-pushed
the
updated-servicesubscriberinterface
branch
from
26503d1 to
d9c56f7
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Symfony 4.2 the ServiceSubscriberInterface has been moved into its own contracts namespace. This commit adds support for the new interface and adds more test-coverage for all possible cases/combinations.
This is a follow-up on #19 (c340de8)