Add stub for form options #419
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
formOptions
branch
3 times, most recently
from
822cc6a to
7c21546
Compare
VincentLanglet
force-pushed
the
formOptions
branch
from
7c21546 to
b8b9ebc
Compare
VincentLanglet
commented
Dec 24, 2024
|
|
||
| public function doSomethingWithInvalidOption(): void | ||
| { | ||
| $form = $this->formFactory->create(DataClassType::class, new DataClass(), ['required' => 42]); |
There was a problem hiding this comment.
I'd like to get an error here saying I pass an integer when a string is expected because DataClassType is
AbstractType<DataClass, array{required: string, optional: int}>
I thought it would have been reported by the CallMethodsRuleTest.
What do I miss @ondrejmirtes ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.