Add EnvelopeReturnTypeExtension for symfony/messenger #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enumag
commented
Mar 28, 2019
| $envelope = new \Symfony\Component\Messenger\Envelope(new stdClass()); | ||
|
|
||
| $test1 = $envelope->all(\Symfony\Component\Messenger\Stamp\ReceivedStamp::class); | ||
| $test2 = $envelope->all(random_bytes(1)); |
There was a problem hiding this comment.
any better way to pass a "non-constant-string" in this test?
lookyman
suggested changes
Mar 28, 2019
| ): Type | ||
| { | ||
| if (count($methodCall->args) === 0) { | ||
| return new ArrayType(new MixedType(), new ArrayType(new MixedType(), new ObjectType(StampInterface::class))); |
There was a problem hiding this comment.
StampInterface needs to be a string here, so that composer require checker doesn't complain. I know, not ideal.
|
|
||
| $argType = $scope->getType($methodCall->args[0]->value); | ||
| if (!$argType instanceof ConstantStringType) { | ||
| return new ArrayType(new MixedType(), new ObjectType(StampInterface::class)); |
|
@lookyman Fixed. In my opinion composer require checker should ignore |
|
@enumag Yes, I think so as well. Some things are still failing, but I'll fix those. Thanks! |
|
@lookyman Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43