Unexpected ClassReflection error starting on v1.7.0

[carlosas]

I'm refactoring PHPat as a PHPStan extension but an error hits me when using PHPStan 1.7.* (which doesn't happen with =<1.6.*)

In ReflectionClass.php line 356:
  Not implemented

Using PHPStan 1.6 ✅ https://github.com/carlosas/phpat/actions/runs/2443831917
Using PHPStan 1.7 ❌ https://github.com/carlosas/phpat/actions/runs/2443854444

I found that this is what is triggering it:
https://github.com/carlosas/phpat/blob/phpstan/src/Test/TestParser.php#L45

Also having PHPStan 1.7.0 installed, psalm complains of UndefinedDocblockClass, but only with php71 and php80, not with php81

Any idea?

[staabm]

Since StaticRelfection is the default as of 1.7.x you should not use native Reflection classes but ReflectionProvider etc

[ondrejmirtes]

@staabm I believe that what he's doing, don't jump to conclusions without checking the source code. The exception is coming from BetterReflection.

[ondrejmirtes]

Please try PHPStan 1.7.11. It should be fixed thanks to: ondrejmirtes/BetterReflection@90dd583

[carlosas]

It does work now 👍 however psalm complains that one of the declared return types of \PHPStan\Reflection\ClassReflection :: getNativeReflection() does not exist. I think this comes because \PHPStan\BetterReflection\Reflection\Adapter\ReflectionEnum extends \ReflectionEnum which only exists from php81. Not sure if I should raise this topic in psalm or it's something that can be fixed here.

https://github.com/carlosas/phpat/runs/6774306401?check_suite_focus=true