Skip to content

Conversation

@stesie
Copy link
Member

@stesie stesie commented Mar 25, 2016

Currently if you pass a JS object to PHP it's wrapped to a V8Object instance.
If you pass this V8Object instance back to JavaScript it's wrapped again, i.e. a different JS object is constructed. That is

  • inconsistent with V8Function behaviour (where we already skip re-wrapping)
  • hurts object identity
  • doesn't work at all if the object is an ES6 Promise

@stesie stesie merged commit 21c8bd2 into phpv8:master Mar 25, 2016
@stesie stesie deleted the fix-v8object-passback branch January 20, 2017 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant