Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for libnode (additional/instead of libv8) #537

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

stesie
Copy link
Member

@stesie stesie commented Sep 29, 2024

refs #522, picking up the idea to use libnode on alpine

@stesie
Copy link
Member Author

stesie commented Sep 29, 2024

@JoshuaBehrens given you recently worked on the auto-detection, what do you think?

Copy link
Contributor

@JoshuaBehrens JoshuaBehrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of it LGTM as you basically just wrapped a loop around it. With this in mind I assume we need a workflow verifying a apk add libnode-ish installation on alpine works out. Right?

ARCH=$(uname -m)

for i in $SEARCH_PATH ; do
echo checking "$i/$PHP_LIBDIR/$SEARCH_FOR" -a -r "$i/include/$libname/v8.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no other echos here. Is this a remaining debug snippet or is it seen helpful for the overall output of the script?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that shouldn't actually go there...

@stesie
Copy link
Member Author

stesie commented Sep 29, 2024

@JoshuaBehrens

With this in mind I assume we need a workflow verifying a apk add libnode-ish installation on alpine works out. Right?

well, I'm unsure if we actually need it. But sure, certainly it is a nice to have. On the other hand I don't want to overact it.

But yes, why not have some jobs next to the matrix one, that builds it on alpine and maybe one on ubuntu.
After all this may also provide guideance to others how the extension can be installed on particular systems

@stesie stesie merged commit 56eb76b into phpv8:php8 Sep 29, 2024
@JoshuaBehrens
Copy link
Contributor

@stesie yes, I also thought about test on package manager based builds. They should not take a lot of minutes and ensure others have easy access to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants