Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ci test on alpine #538

Merged
merged 2 commits into from
Sep 29, 2024
Merged

add ci test on alpine #538

merged 2 commits into from
Sep 29, 2024

Conversation

stesie
Copy link
Member

@stesie stesie commented Sep 29, 2024

No description provided.

@@ -94,3 +94,27 @@ jobs:
./configure --with-v8js=/opt/v8/self-built LDFLAGS="-lstdc++" CPPFLAGS="-DV8_COMPRESS_POINTERS -DV8_ENABLE_SANDBOX"
make
make test

alpine:
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this how one runs alpine on GitHub Workflows? :D weird concept but if it works

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, found it weird as well :)

... but there's no runner image with alpine

@JoshuaBehrens
Copy link
Contributor

Feels like we want to have the phpt test results as artifact on the run so one can view them? One should be able to get into this without having to run it locally again.

Do you want to save this report in a file? [Yn]: Report saved to: /home/runner/work/v8js/v8js/php_test_results_20240929_1624.txt

I assume something like this would be beneficial to better understand issues reported online

      - name: Archive test results
        if: always()
        uses: actions/upload-artifact@v4
        with:
          name: phpt-test-results
          path: php_test_results*.txt

@stesie
Copy link
Member Author

stesie commented Sep 29, 2024

d'accord, collection makes sense. I've added it in failure case only though.
Seems to work fine -> https://github.com/phpv8/v8js/actions/runs/11094647649/job/30822343118

And I've compiled 11.3.244.8 on my Ubuntu machine "quickly", and there the test fails as well. Seems like an issue with V8 itself, that the setter is invoked twice there. Unfortunate that it ocurs on exactly the version that's shipped with alpine, but I would just ignore it for the moment (i.e. skip this particular test for that V8 version)

@stesie stesie merged commit 5234490 into phpv8:php8 Sep 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants