Ensure MacOS support by tests #539
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This error is weird This method exists for over 25 years and the file is included :D |
JoshuaBehrens
force-pushed
the
feature/build-on-macos-brew
branch
7 times, most recently
from
28b917c to
3fe1f39
Compare
Merged
JoshuaBehrens
force-pushed
the
feature/build-on-macos-brew
branch
11 times, most recently
from
d2b18ca to
658bd2b
Compare
Change GitHub actions to include more and more detailed tests Rename other workflow targets to better explain the differences between the runs Add more php versions to default build test to ensure complete range is tested Add macos to self-built tests Make artifact names unique per step Extract v8 cache building to run less often to reduce computation costs Ensure to use right architecture on built-target Speed up v8 fetch
JoshuaBehrens
force-pushed
the
feature/build-on-macos-brew
branch
2 times, most recently
from
77a3680 to
af78606
Compare
JoshuaBehrens
force-pushed
the
feature/build-on-macos-brew
branch
from
af78606 to
c42f095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are either necessary steps or helpful changes to let this run on MacOS. I have further changes to do so this is just a draft