Make file_format and locale_id required params

phrase · Apr 19, 2024 · cdb0251 · cdb0251
1 parent 23f639d
commit cdb0251
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 11 deletions.
diff --git a/clients/go/test/api_uploads_test.go b/clients/go/test/api_uploads_test.go
diff --git a/clients/java/src/test/java/com/phrase/client/api/UploadsApiTest.java b/clients/java/src/test/java/com/phrase/client/api/UploadsApiTest.java
@@ -92,8 +92,8 @@ public void uploadCreateTest() throws ApiException, IOException, InterruptedExce
         String branch = "branch_example";
         File file = File.createTempFile("test", "test");
         file.deleteOnExit();
-        String fileFormat = null;
-        String localeId = null;
+        String fileFormat = "simple_json";
+        String localeId = "en";
         String tags = null;
         Boolean updateTranslations = null;
         Boolean updateDescriptions = null;
@@ -106,7 +106,7 @@ public void uploadCreateTest() throws ApiException, IOException, InterruptedExce
         Boolean autotranslate = null;
         Boolean markReviewed = null;
         Boolean tagOnlyAffectedKeys = null;
-        Upload response = api.uploadCreate(projectId, file, xPhraseAppOTP, branch, fileFormat, localeId, tags, updateTranslations, updateDescriptions, convertEmoji, skipUploadTags, skipUnverification, fileEncoding, localeMapping, formatOptions, autotranslate, markReviewed, tagOnlyAffectedKeys);
+        Upload response = api.uploadCreate(projectId, file, fileFormat, localeId, xPhraseAppOTP, branch, tags, updateTranslations, updateDescriptions, convertEmoji, skipUploadTags, skipUnverification, fileEncoding, localeMapping, formatOptions, autotranslate, markReviewed, tagOnlyAffectedKeys);
 
         Assert.assertEquals("valid id returned", "id_example", response.getId());
         Assert.assertEquals("valid creation date returned", OffsetDateTime.parse("2015-01-28T09:52:53Z"), response.getCreatedAt());

diff --git a/clients/php/test/Api/UploadsApiTest.php b/clients/php/test/Api/UploadsApiTest.php
@@ -107,7 +107,7 @@ public function testUploadCreate()
         $file = new \SplFileObject($fileName, 'w+');
         $file->fwrite('test');
 
-        $result = $this->apiInstance->uploadCreate($projectId, $file, null, null);
+        $result = $this->apiInstance->uploadCreate($projectId, $file, "yml", "en", null, null);
         $file = null;
         unlink($fileName);
 

diff --git a/clients/python/test/test_uploads_api.py b/clients/python/test/test_uploads_api.py
@@ -48,7 +48,8 @@ def test_upload_create(self, mock_post):
             api_response = api_instance.upload_create(
                 project_id,
                 file="./test/fixtures/en.json",
-                file_format="simple_json"
+                file_format="simple_json",
+                locale_id="en"
             )
 
             self.assertEqual("https://api.phrase.com/v2/projects/project_id_example/uploads", mock_post.call_args_list[0].args[1])

diff --git a/clients/ruby/spec/api/uploads_api_spec.rb b/clients/ruby/spec/api/uploads_api_spec.rb
@@ -53,7 +53,7 @@
     end
 
     it 'should work' do
-      @api_instance.upload_create('project_id', file: File.new('Gemfile'))
+      @api_instance.upload_create('project_id', File.new('Gemfile'), "yml", "en")
 
       expect(a_request(:post, 'https://api.phrase.com/v2/projects/project_id/uploads')
         .with { |req|

diff --git a/clients/typescript/__tests__/BasicApiTest.ts b/clients/typescript/__tests__/BasicApiTest.ts
@@ -89,8 +89,10 @@ describe('UploadsApi', () => {
     test('uploads a file', async () => {
       const projectId = 'my-project-id';
       const file = fs.createReadStream('package.json');
+      const fileFormat = 'json';
+      const localeId = 'en';
 
-      await api.uploadCreate({projectId, file}).then((response) => {
+      await api.uploadCreate({projectId, file, fileFormat, localeId}).then((response) => {
         expect(response.id).toBe('upload_id');
       });
 

diff --git a/paths/uploads/create.yaml b/paths/uploads/create.yaml
@@ -61,6 +61,8 @@ requestBody:
         title: upload/create/parameters
         required:
           - file
+          - file_format
+          - locale_id
         properties:
           file:
             description: File to be imported