refactor!: add missing required params #571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve documentation of required params. This will be a breaking change for some endpoints in the libraries and will be released in a new major version. It's not a breaking change for the REST API itself as these param were already required before and returned a 422 in case they were missing
The following endpoints now have additional required parameters:
authorizations#create
-note
is requiredblacklisted_keys#create
-name
is requiredbranches#create
-name
is requireddistributions#create
-name
,project_id
are requiredfigma_attachements#create
-url
is requiredglossaries#create
-name
is requiredglossary_term_translations#create
-locale_code
,content
are requiredglossary_terms#create
-term
is requiredinvitations#create
-email
,role
are requiredjobs#create
-name
is requiredkeys#create
-name
is requiredlocales#create
-name
,code
are requiredorders#create
-name
,lsp
are requiredprojects#create
-name
is requiredscreenshot_markers#create
-key_id
is requiredspaces#create
-name
is requiredstyleguides#create
-title
is requiredtags#create
-name
is requiredteams#add_project
-id
is requiredteam#add_space
-id
is requiredteams#add_user
-id
is requiredteams#create
-name
is requiredtranslations#create
-locale_id
,key_id
are requireduploads#create
-file
,file_format
,locale_id
are requiredvariables#create
-name
is requiredwebhooks#create
-callback_url
is required