-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add Python tests #427
Conversation
b95b850
to
3c99e93
Compare
54bf749
to
8c3b9fa
Compare
8c3b9fa
to
5b84c41
Compare
clients/python/ | ||
|
||
clients/python/* | ||
!clients/python/test/test_locales_api.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure that this works, as one can't exclude a single file when the whole directory has been ignored.
It is not possible to re-include a file if a parent directory of that file is excluded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jablan it works for me. Just had to run git add -f filepath
to add it initially. After adding it initially all changes in that file show up as a diff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is !clients/python/test/test_locales_api.py
needed then at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Doesn't make a difference at all. Then the question is whether we should explicitly exclude all other files or we perform git add -f
for files we want to track in the future. In both cases we manually we to add the .gitignore entry or run the command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm somehow I thought that git won't recognize changes in a file even if it's force-added, but it doesn't seem to be the case. in that case, I think it's easier to do git add -f
whenever we add a new file that needs to be preserved, rather than maintaining this weird structure in .gitignore
.
Add basic tests for Python