Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add Python tests #427

Merged
merged 1 commit into from
Oct 13, 2023
Merged

test: Add Python tests #427

merged 1 commit into from
Oct 13, 2023

Conversation

theSoenke
Copy link
Collaborator

Add basic tests for Python

@theSoenke theSoenke changed the base branch from master to tsi-1874-update-generator-v7 October 12, 2023 13:01
@theSoenke theSoenke force-pushed the python-tests branch 4 times, most recently from b95b850 to 3c99e93 Compare October 12, 2023 13:06
@theSoenke theSoenke changed the base branch from tsi-1874-update-generator-v7 to master October 12, 2023 13:06
@theSoenke theSoenke force-pushed the python-tests branch 3 times, most recently from 54bf749 to 8c3b9fa Compare October 12, 2023 13:49
@theSoenke theSoenke marked this pull request as ready for review October 12, 2023 13:53
clients/python/

clients/python/*
!clients/python/test/test_locales_api.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure that this works, as one can't exclude a single file when the whole directory has been ignored.

It is not possible to re-include a file if a parent directory of that file is excluded.

https://git-scm.com/docs/gitignore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jablan it works for me. Just had to run git add -f filepath to add it initially. After adding it initially all changes in that file show up as a diff

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is !clients/python/test/test_locales_api.py needed then at all?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Doesn't make a difference at all. Then the question is whether we should explicitly exclude all other files or we perform git add -f for files we want to track in the future. In both cases we manually we to add the .gitignore entry or run the command

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm somehow I thought that git won't recognize changes in a file even if it's force-added, but it doesn't seem to be the case. in that case, I think it's easier to do git add -f whenever we add a new file that needs to be preserved, rather than maintaining this weird structure in .gitignore.

@theSoenke theSoenke merged commit b27c83f into master Oct 13, 2023
9 checks passed
@theSoenke theSoenke deleted the python-tests branch October 13, 2023 07:23
@jablan jablan mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants