Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(API): add Custom Metadata endpoints #474
feat(API): add Custom Metadata endpoints #474
Changes from 27 commits
b85b5e5
882ef70
7f5fc17
6f2d259
43729e1
037c904
6b554f7
08891f7
dc31638
aedb4e6
63c52fd
8bb7161
3685a03
d4a742f
e84fe71
218eeb6
033db1c
da0c66c
e22dae6
9c0a121
a56a258
001effc
b56d328
d4b469d
fcd8cbe
0978091
7ca6c3d
08771e7
dcd320e
b400e82
7b636a6
c42fbea
42e7a82
74275df
4fdbef0
504fb40
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious, why is there a data_type parameter? is it for filtering properties only for the given type? what was the use case for adding this?
in phrase code, I can see there's also
q
parameter (which makes more sense IMO), why has it been left out?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, believe so
perhaps a convenience method of getting all date-related properties for mass update?