feat: Add linked-parent to translation details #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlumMichael
requested review from
forelabs,
bikmazefe,
ildarsafin,
anthonyshchang and
malvarezphrase
malvarezphrase
approved these changes
Apr 18, 2024
clients/cli/go.sum
Outdated
There was a problem hiding this comment.
Comment: Not sure about the changes in this file, but the rest LGTM!
There was a problem hiding this comment.
That is actually a good question.
Can you help here please @theSoenke ?
I recompiled everything with npm start and committed every change. Is it okay to also add the changes in this file clients/cli/go.sum? Why are those lines removed?
There was a problem hiding this comment.
I don't know why are these lines removed. I don't think it would break anything if committed, but I'd keep it out of the PR.
malvarezphrase
approved these changes
Apr 19, 2024
BlumMichael
deleted the
TSS-3171-update-open-api-doc-for-translation-details
branch
This was referenced Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "linked_parent" to translation-details.
https://phrase.atlassian.net/browse/TSS-3171