Use flag to selectively enable treat_warnings_as_errors. #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to enable treat_warnings_as_errors only if we're building the main repository (to isolate users from warnings), and only for the targets in our repository. Specifying a private flag in .bazelrc seems to be the simplest way to achieve this. This partially reverts commit 0ae8e08.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to enable treat_warnings_as_errors only if we're building the main repository (to isolate users from warnings), and only for the targets in our repository. Specifying a private flag in .bazelrc seems to be the simplest way to achieve this.
This partially reverts commit 0ae8e08.