Make Shoryuken compatibility with aws-sdk-core 2 and 3 #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
phstc
commented
Sep 2, 2017
lib/shoryuken.rb
Outdated
| end | ||
| rescue LoadError | ||
| fail "AWS SDK 3 requires aws-sdk-sqs to be installed separately. Please add gem 'aws-sdk-sqs' to your Gemfile" | ||
| end |
There was a problem hiding this comment.
@pyromaniac Aws::CORE_GEM_VERSION is the one that returns the version. But I think only by checking if Aws::SQS we can infer if 3 or not.
phstc
force-pushed
the
feature/add-compatibility-with-aws-sdk-v2-and-3
branch
10 times, most recently
from
a7c1150
to
76edb81
Compare
phstc
force-pushed
the
feature/add-compatibility-with-aws-sdk-v2-and-3
branch
from
76edb81
to
a36d6e9
Compare
|
I think it is perfect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #430