Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sdk-sqs is required #430

Closed
pyromaniac opened this issue Aug 31, 2017 · 5 comments
Closed

aws-sdk-sqs is required #430

pyromaniac opened this issue Aug 31, 2017 · 5 comments

Comments

@pyromaniac
Copy link

Hey, seems like for aws-sdk-core V3, aws-sdk-sqs dependency is required. Probably it worth to add this at least to readme.
@phstc
Copy link
Collaborator

phstc commented Aug 31, 2017

@pyromaniac v3 shouldn't be required. What's the error are you getting?

@pyromaniac
Copy link
Author

This one: https://travis-ci.org/toptal/chewy/jobs/270283525
toptal/chewy@3c68a23 - this patch helped

@phstc phstc changed the title aws-sdk-sqs is reqired aws-sdk-sqs is required Aug 31, 2017
@phstc
Copy link
Collaborator

phstc commented Aug 31, 2017

@pyromaniac Alright, how about this?

@pyromaniac
Copy link
Author

pyromaniac commented Aug 31, 2017 •
edited
Loading

the patch will help simply by falling back to v2. But I think it is the right direction chosen at the moment, we want to use > 2 or >=2 (and probably run travis for both of the versions in this case), but v3 still requires an additional gem to be installed and required.

@phstc phstc mentioned this issue Sep 2, 2017
Merged
@phstc phstc closed this as completed in #433 Sep 2, 2017
phstc added a commit that referenced this issue Sep 2, 2017
@phstc
Merge pull request #433 from phstc/feature/add-compatibility-with-aws…
8f54c26 
…-sdk-v2-and-3

Make Shoryuken compatibility with aws-sdk-core 2 and 3

Fixes #430
@phstc
Copy link
Collaborator

phstc commented Sep 2, 2017

@pyromaniac thanks! 3.1.10 is out with the compatibility fixes! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pyromaniac @phstc