Remove the unsafe code in Table::as_ref #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pinkforest, I heard you maintain prettytable these days - could you please merge this PR? It's causing segfaults in the rustc perf tools. |
|
Yeah sure thanks for the reminder, I will cut a release today with this. Need to see what else needed merging. |
Closed
|
Release 0.10.0 is out with this. |
thegwan
added a commit
to thegwan/retina
that referenced
this pull request
Apr 20, 2023
thegwan
added a commit
to stanford-esrg/retina
that referenced
this pull request
Apr 20, 2023
* upgrade dependencies * fix new clippy warnings * update CI toolchain 1.63.0 -> 1.69.0 * bump prettytable version: phsym/prettytable-rs#146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #145