Updates to fix ruby 2.2. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility with older versions of ruby.
|
Passing tests:
|
|
👍 |
|
@FooBarWidget Can I get a review please? |
|
Looks good. Thanks for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes digest-sha3-ruby to work with the changes made by
Major version upgrade as this breaks compatibility with older versions of ruby.
The main difficulty of this implementation was that it was using internals of digest.h to create a variable length digest class, and digest.h assumes non-variable length digests; which was highly problematic for the changes made to the base class Digest::Base. The original rb_alloc had to be ditched for compatibility. Now the variable length adjustments are done in the constructor and final is senstivie to the size of the digest intended.