Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0: FIPS 202 SHA-3 standard hash algorithms and SHAVS test vectors, except SHAKE* #6

Closed
wants to merge 4 commits into from

Conversation

skull-squadron
Copy link

Closes #5. #3 can also be closed.

@skull-squadron
Copy link
Author

@skull-squadron skull-squadron changed the title 2.0.0: FIPS 202 SHA-3 standard hash algorithms, except SHAKE* 2.0.0: FIPS 202 SHA-3 standard hash algorithms and SHAVS test vectors, except SHAKE* Mar 21, 2016
@skull-squadron
Copy link
Author

Ready for merging and release.

cc: @FooBarWidget

@q9f
Copy link

q9f commented Sep 30, 2021

This should not be merged for historical reasons. If you are looking for SHA3 as per final FIPS standard, use the sha3 gem.

This repository implements a non-final version that is required by many Ethereum centric libraries though. Ethereum developers should use the keccak gem, therefore.

Copy link

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now there is the keccak gem to keep the 1.x implementation, it can make sense to upgrade this gem to the latest implementation.

@skull-squadron skull-squadron closed this by deleting the head repository Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper SHA3 implementation?
3 participants