Feature request: passenger-memory-stats: add option to disable apache/nginx checks #2306
Labels
Comments
64kramsystem
changed the title
64kramsystem
changed the title
64kramsystem
added a commit
to 64kramsystem/passenger-dev
that referenced
this issue
Sep 18, 2020
Allow skipping the Apache/Nginx sections of the passenger-memory-stats output, through the `--no-apache` and `--no-nginx` commandline options. The output without any option specified is the same. When specifying each of the two options, the section is entirely removed. This causes a difference in spacing between sections, as the Apache section doesn't have leading newlines, while the Nginx/Passenger ones do. Example: ``` $ passenger-mem-stats Version: 6.0.2 Date : 2020-09-18 12:17:42 +0200 [APACHE SECTION] [NGINX SECTION] [PASSENGER SECTION] $ passenger-mem-stats --no-nginx Version: 6.0.2 Date : 2020-09-18 12:17:42 +0200 [NGINX SECTION] [PASSENGER SECTION] ``` This is arguably a negligible difference. I originally looked into removing it, but it seems that the Table class introduces a leading newline (after the escape sequences) for Nginx/Passenger, while it doesn't do it for Apache, so I thought it's not really worth changing that. Closes phusion#2306.
CamJN
pushed a commit
that referenced
this issue
Sep 21, 2020
Allow skipping the Apache/Nginx sections of the passenger-memory-stats output, through the `--no-apache` and `--no-nginx` commandline options. The output without any option specified is the same. When specifying each of the two options, the section is entirely removed. This causes a difference in spacing between sections, as the Apache section doesn't have leading newlines, while the Nginx/Passenger ones do. Example: ``` $ passenger-mem-stats Version: 6.0.2 Date : 2020-09-18 12:17:42 +0200 [APACHE SECTION] [NGINX SECTION] [PASSENGER SECTION] $ passenger-mem-stats --no-nginx Version: 6.0.2 Date : 2020-09-18 12:17:42 +0200 [NGINX SECTION] [PASSENGER SECTION] ``` This is arguably a negligible difference. I originally looked into removing it, but it seems that the Table class introduces a leading newline (after the escape sequences) for Nginx/Passenger, while it doesn't do it for Apache, so I thought it's not really worth changing that. Closes #2306.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue report
This is a feature request, so I'm keeping the information minimal, as it's not related to any specific O/S or Passenger aspect.
Question 1: What is the problem?
The tool
passenger-memory-statsalways check for both Apache and Nginx status. Since it's unlikely (I suppose) that both are active at the same time, any invocation inevitably causes a warning to be printed, cluttering the output (and potentially, the exit status).My request is to add option(s) to disable the checks. The behavior can be left as is by default, so the additional logic affects exclusively invocations that explicitly disable the checks.
I'm going to create a prototype/proposed PR over the next days, so this is for tracking and discussion.
The text was updated successfully, but these errors were encountered: