Add a PASSENGER_MAX_LOG_LINE_BYTES option increase the number of characters allowed per log line #2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er of characters allowed per log loine
|
This does a dynamic allocation in the hot path, it'll be too slow. Sorry. |
Would it be acceptable to have it as a start-up arg then that's passed down to the PipeWatcher? If I'm understanding you correctly, you're suggesting that dynamically allocating the value where I've done it is too late and inefficient. |
|
Just moving the allocation into the constructor might be enough, i'd recommend trying that and running a test to see how it performs. |
I've taken a stab at this in #2458 since this PR has maybe stalled? |
|
superseded by other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to resolve #2413
My particular issue with Passenger splitting logs into multiple lines is that we use Filebeat to pipe logs to Logstash, and Logstash expects our Rails logging to be in
jsonformat. In cases where we have long stack traces, these multiline logs end up not being parsed correctly (with a_jsonparsefailureon the Logstash side). Whilst there are multiline configurations available for both Filebeat and Logstash, it's recommended to use mulitline configs in Filebeat over Logstash. However, since Passenger appendsApp #{pid} output:to each of the log lines, it means we'd need to strip out the extra text before stitching logs together. Whilst I also know the latest version of passenger contains the option to remove theApp #{pid} output:prefix, it feels a bit simpler to just be able to configure Passenger to log larger contents into a single line without breaking it up.I tried looking at previous pull requests to figure out whether there's anywhere I would need to add this to the documentation, but couldn't find anything. Happy to add it if I'm pointed in the right direction.
Any feedback would be great! Thanks :)